-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation about enabling RBAC in minikube #498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Actually now I am not sure if this is needed. Doesn't kubeadm now bootstraps with RBAC enabled by default? cc/ @prydonius @andresmgot |
@migmartri I wasn't 100% sure tbh, but indeed it looks like from 0.26+ kubeadm is the default bootstrapper and RBAC is enabled by default: kubernetes/minikube#1722 (comment). |
Can you update the doc to just have |
yes, I confirm that RBAC is enabled by default in the latest minikube (I tried with v0.28.2) so |
docs/developer/tiller-proxy.md
Outdated
@@ -44,7 +44,7 @@ This builds the `tiller-proxy` binary in the working directory. | |||
If you are using Minikube it is important to start the cluster enabling RBAC (in order to check the authorization features): | |||
|
|||
``` | |||
minikube start --extra-config=apiserver.Authorization.Mode=RBAC | |||
minikube start --extra-config=apiserver.authorization-mode=RBAC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove --extra-config
parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
https://kubernetes.io/docs/setup/minikube/#examples should also be updated |
Minikube 0.26+ fails to start if the flag
--Authorization.Mode
is passed with the errorThis updates the docs to use the configuration that Kubeadm understands.
kubernetes/minikube#2712 (comment)